Repository navigation
Conversation
|
I'm never able to remind the value of hexadecimal version numbers such as |
|
This looks like churn to me -- especially with the pre-3.10 versions. |
|
To me, |
|
I agree that this is a significant readability improvement. I can't read hexadecimals either. |
|
I won't block this. But it's the kind of thing that makes backports annoying. |
|
Can we at least limit this to 3.10+? I have no strong opinion. It is a churn, but hexadecimal versions are less readable and more errorprone. |
Move _Py_PACK_VERSION() from pymacro.h to patchlevel.h.
PR generated with these shell commands on Linux:
HEADERS=$(find Include -name "*.h")
sed -i -e "s#0x030[aA]0000#_Py_PACK_VERSION(3, 10)#g" $HEADERS
sed -i -e "s#0x030[bB]0000#_Py_PACK_VERSION(3, 11)#g" $HEADERS
sed -i -e "s#0x030[cC]0000#_Py_PACK_VERSION(3, 12)#g" $HEADERS
sed -i -e "s#0x030[dD]0000#_Py_PACK_VERSION(3, 13)#g" $HEADERS
sed -i -e "s#0x030[eE]0000#_Py_PACK_VERSION(3, 14)#g" $HEADERS
sed -i -e "s#0x030[fF]0000#_Py_PACK_VERSION(3, 15)#g" $HEADERS
sed -i -e "s#0x030a00A7#_Py_PACK_VERSION(3, 10)#g" Include/refcount.h
ef5ef68 to
97324a0
Compare
|
@serhiy-storchaka, @ZeroIntensity: Would you mind reviewing the updated PR? I reverted changes on versions 3.0 to 3.9.
Ok. I regenerated the PR to only replace versions 3.10 and newer. The PR is now way smaller. Note: I used |
Revert also pyabi.h changes.
ZeroIntensity
left a comment
There was a problem hiding this comment.
I think pre-3.10 stuff would be fine to do as well, but I'm happy with this too.
|
Sanitizers / TSan (free-threading): test_capi fails. It should be fixed by #162154. |
Move _Py_PACK_VERSION() from pymacro.h to patchlevel.h.
PR generated with these shell commands on Linux: