Skip to content

gh-162034: Quote paths in the Apple testbed's utils.sh - #162161

Merged
freakboy3742 merged 1 commit into
python:mainfrom
fametrano:apple-testbed-quote-utils
Nov 17, 2026
Merged

freakboy3742 merged 1 commit into
python:mainfrom
fametrano:apple-testbed-quote-utils

Conversation

@fametrano

@fametrano fametrano commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Quoting paths and using read -r fix how the Apple testbed converts extension modules when a path holds a space, brackets or a backslash. A space in a package or XCframework path left modules unconverted or failed the build. Brackets in the build path put all modules in one misnamed framework. A backslash there made mv fail.

On this branch, every case of the script from #162034 exits 0, with each module in its own framework.

install_python left several paths unquoted. A space in a package path
or in the XCframework path split it, so modules were left unconverted
or the build failed. Brackets in the build path broke the prefix strip,
so all modules went into one misnamed framework. read without -r dropped
a backslash from the build path, so mv failed.

Quote these paths and the variables used as patterns in ${...}, and
use read -r.

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@freakboy3742 freakboy3742 added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Nov 17, 2026
@freakboy3742
freakboy3742 merged commit 3ad9316 into python:main Nov 17, 2026
64 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @fametrano for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @fametrano and @freakboy3742, I could not cleanly backport this to 3.15 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 3ad9316217ba4e2788abc7d19f469762c6c38309 3.15

@miss-islington-app

Copy link
Copy Markdown

Sorry, @fametrano and @freakboy3742, I could not cleanly backport this to 3.14 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 3ad9316217ba4e2788abc7d19f469762c6c38309 3.14

@bedevere-app

bedevere-app Bot commented Nov 17, 2026

Copy link
Copy Markdown

GH-162180 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs backport to 3.14 bugs and security fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants