Skip to content

gh-162170: Makefile: have "install" depend on pgo - #95287

Merged
itamaro merged 4 commits into
python:mainfrom
kmod:install_pgo
Nov 17, 2026
Merged

itamaro merged 4 commits into
python:mainfrom
kmod:install_pgo

Conversation

@kmod

@kmod kmod commented Jul 26, 2022 •

Copy link
Copy Markdown
Contributor

Previously, make install would ignore pgo. This isn't an
issue if one runs make && make install, since make will
build with pgo (if requested) and then make install won't
rebuild anything.

But if one simply does ./configure --enable-optimizations && make install,
the build system would build a non-pgo build and then install that.

This commit changes the Makefile so that install depends on
all, which includes pgo when requested.

Previously, `make install` would ignore pgo. This isn't an
issue if one runs `make && make install`, since `make` will
build with pgo (if requested) and then `make install` won't
rebuild anything.

But if one simply does `./configure --enable-optimizations && make install`,
the build system would build a non-pgo build and then install that.

This commit changes the Makefile so that `install` depends on
`all`, which includes pgo when requested.
@ghost

ghost commented Jul 26, 2022 •

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 11, 2026
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Oct 23, 2026
@emmatyping

Copy link
Copy Markdown
Member

Hi @kmod, can you please add a news entry?

@kmod

kmod commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

Hi @emmatyping, I stopped working on CPython a while ago and no longer have a checkout of it or context on this issue, I'm happy to let anyone else pick this up if that makes sense. fyi the blurb_it web app seems to be down.

@itamaro itamaro changed the title Makefile: have "install" depend on pgo gh-162170: Makefile: have "install" depend on pgo Nov 17, 2026
@itamaro itamaro added build The build process and cross-build needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Nov 17, 2026
@itamaro
itamaro enabled auto-merge (squash) November 17, 2026 20:31
@itamaro
itamaro merged commit 715d34f into python:main Nov 17, 2026
58 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @kmod for the PR, and @itamaro for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Nov 17, 2026

Copy link
Copy Markdown

GH-162176 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 17, 2026
@bedevere-app

bedevere-app Bot commented Nov 17, 2026

Copy link
Copy Markdown

GH-162177 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 17, 2026
itamaro pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2026
Previously, `make install` would ignore PGO. This isn't an
issue if one runs `make && make install`, since `make` will
build with pgo (if requested) and then `make install` won't
rebuild anything.

But if one simply does `./configure --enable-optimizations && make install`,
the build system would build a non-PGO build and then install that.

This commit changes the Makefile so that `install` depends on
`all`, which includes PGO when requested.
(cherry picked from commit 715d34f)

Co-authored-by: Kevin Modzelewski <kevmod@gmail.com>
itamaro pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2026
Previously, `make install` would ignore PGO. This isn't an
issue if one runs `make && make install`, since `make` will
build with pgo (if requested) and then `make install` won't
rebuild anything.

But if one simply does `./configure --enable-optimizations && make install`,
the build system would build a non-PGO build and then install that.

This commit changes the Makefile so that `install` depends on
`all`, which includes PGO when requested.
(cherry picked from commit 715d34f)

Co-authored-by: Kevin Modzelewski <kevmod@gmail.com>
itamaro pushed a commit that referenced this pull request Nov 17, 2026
…162176)

gh-162170: Makefile: have "install" depend on pgo (GH-95287)

Previously, `make install` would ignore PGO. This isn't an
issue if one runs `make && make install`, since `make` will
build with pgo (if requested) and then `make install` won't
rebuild anything.

But if one simply does `./configure --enable-optimizations && make install`,
the build system would build a non-PGO build and then install that.

This commit changes the Makefile so that `install` depends on
`all`, which includes PGO when requested.
(cherry picked from commit 715d34f)

Co-authored-by: Kevin Modzelewski <kevmod@gmail.com>
itamaro pushed a commit that referenced this pull request Nov 17, 2026
…162177)

gh-162170: Makefile: have "install" depend on pgo (GH-95287)

Previously, `make install` would ignore PGO. This isn't an
issue if one runs `make && make install`, since `make` will
build with pgo (if requested) and then `make install` won't
rebuild anything.

But if one simply does `./configure --enable-optimizations && make install`,
the build system would build a non-PGO build and then install that.

This commit changes the Makefile so that `install` depends on
`all`, which includes PGO when requested.
(cherry picked from commit 715d34f)

Co-authored-by: Kevin Modzelewski <kevmod@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build The build process and cross-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants