Repository navigation
gh-162170: Makefile: have "install" depend on pgo - #95287
Merged
Merged
Conversation
Previously, `make install` would ignore pgo. This isn't an issue if one runs `make && make install`, since `make` will build with pgo (if requested) and then `make install` won't rebuild anything. But if one simply does `./configure --enable-optimizations && make install`, the build system would build a non-pgo build and then install that. This commit changes the Makefile so that `install` depends on `all`, which includes pgo when requested.
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
This PR is stale because it has been open for 30 days with no activity. |
ambv
requested review from
AA-Turner,
emmatyping,
erlend-aasland and
itamaro
as code owners
October 22, 2026 21:32
Member
|
Hi @kmod, can you please add a news entry? |
Contributor
Author
|
Hi @emmatyping, I stopped working on CPython a while ago and no longer have a checkout of it or context on this issue, I'm happy to let anyone else pick this up if that makes sense. fyi the blurb_it web app seems to be down. |
itamaro
approved these changes
Nov 17, 2026
itamaro
enabled auto-merge (squash)
November 17, 2026 20:31
|
GH-162176 is a backport of this pull request to the 3.15 branch. |
|
GH-162177 is a backport of this pull request to the 3.14 branch. |
itamaro
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 17, 2026
Previously, `make install` would ignore PGO. This isn't an issue if one runs `make && make install`, since `make` will build with pgo (if requested) and then `make install` won't rebuild anything. But if one simply does `./configure --enable-optimizations && make install`, the build system would build a non-PGO build and then install that. This commit changes the Makefile so that `install` depends on `all`, which includes PGO when requested. (cherry picked from commit 715d34f) Co-authored-by: Kevin Modzelewski <kevmod@gmail.com>
itamaro
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 17, 2026
Previously, `make install` would ignore PGO. This isn't an issue if one runs `make && make install`, since `make` will build with pgo (if requested) and then `make install` won't rebuild anything. But if one simply does `./configure --enable-optimizations && make install`, the build system would build a non-PGO build and then install that. This commit changes the Makefile so that `install` depends on `all`, which includes PGO when requested. (cherry picked from commit 715d34f) Co-authored-by: Kevin Modzelewski <kevmod@gmail.com>
itamaro
pushed a commit
that referenced
this pull request
Nov 17, 2026
…162176) gh-162170: Makefile: have "install" depend on pgo (GH-95287) Previously, `make install` would ignore PGO. This isn't an issue if one runs `make && make install`, since `make` will build with pgo (if requested) and then `make install` won't rebuild anything. But if one simply does `./configure --enable-optimizations && make install`, the build system would build a non-PGO build and then install that. This commit changes the Makefile so that `install` depends on `all`, which includes PGO when requested. (cherry picked from commit 715d34f) Co-authored-by: Kevin Modzelewski <kevmod@gmail.com>
itamaro
pushed a commit
that referenced
this pull request
Nov 17, 2026
…162177) gh-162170: Makefile: have "install" depend on pgo (GH-95287) Previously, `make install` would ignore PGO. This isn't an issue if one runs `make && make install`, since `make` will build with pgo (if requested) and then `make install` won't rebuild anything. But if one simply does `./configure --enable-optimizations && make install`, the build system would build a non-PGO build and then install that. This commit changes the Makefile so that `install` depends on `all`, which includes PGO when requested. (cherry picked from commit 715d34f) Co-authored-by: Kevin Modzelewski <kevmod@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
make installwould ignore pgo. This isn't anissue if one runs
make && make install, sincemakewillbuild with pgo (if requested) and then
make installwon'trebuild anything.
But if one simply does
./configure --enable-optimizations && make install,the build system would build a non-pgo build and then install that.
This commit changes the Makefile so that
installdepends onall, which includes pgo when requested.make installright after./configure --enable-optimizationsinstalls a non-PGO interpreter #162170