Skip to content

Workflow improvements - #7779

Merged
pelwell merged 2 commits into
raspberrypi:rpi-6.18.yfrom
pelwell:workflow
Nov 19, 2026
Merged

pelwell merged 2 commits into
raspberrypi:rpi-6.18.yfrom
pelwell:workflow

Conversation

@pelwell

@pelwell pelwell commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

TIghten up the security of the workflows, and use the branch-specific in-tree checkpatch script rather than a random old version.

Apply some standard GitHub Actions security measures:

- Limit the GITHUB_TOKEN to read-only repository access with a
  top-level "permissions: contents: read", rather than relying on the
  repository default, which may grant write access.
- Set "persist-credentials: false" on all checkouts so the token is not
  left in .git/config for later build steps to read.
- Pin all actions to commit SHAs instead of mutable tags, guarding
  against a compromised tag being moved to malicious code. This is most
  important for the third-party webispy/checkpatch-action. At the same
  time, update actions/checkout to v7.0.1 and actions/upload-artifact
  to v7.0.2; neither has breaking changes relevant to these workflows.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
webispy/checkpatch-action runs checkpatch.pl from its webispy/checkpatch
Docker image, which was last built in February 2023. That copy is
missing years of upstream changes, and still applies the networking
block comment rule dropped in commit 82b8000 ("net: drop special
comment style"), so it reports warnings that local runs don't.

Point the action's CHECKPATCH_COMMAND at the PR's own
scripts/checkpatch.pl so each branch is checked against its own rules.

Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
@pelwell
pelwell merged commit 9c2e5cf into raspberrypi:rpi-6.18.y Nov 19, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant