Repository navigation
Make Crypt3's salt from SecureRandom - #346
Merged
Merged
Conversation
generate_salt used rand, which isn't a cryptographic source and follows srand. Facets already uses SecureRandom for salted digests. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crypt3.generate_saltpicked each character withrand, which isn't a cryptographic random source and repeats aftersrand. That salt is also the oneCrypt3.cryptuses when it's given none. It now usesSecureRandom.random_number.The salt's size and character set are unchanged, and so are hashes made with a given salt.
securerandomships with Ruby, and Facets already requires it infacets/digest/salted_digest.Testing
srandtwice and checks the two salts differ. It fails without the change and passes with it.test/standard/test_crypt3.rb: 14 tests passing;rake test:standardandrake qed:codepass on Ruby 3.4.9.🤖 Generated with Claude Code