Repository navigation
Bundle the TAP-Y and TAP-J reporters - #11
Merged
Merged
Conversation
Bring both in from rubytest-tap and restore the -y and -j shortcuts, which were removed because the formats weren't in the gem. The TAP-Y stream now opens with a YAML document (rubytest-tap wrote the suite record as JSON), the TAP-J stream no longer ends with a `...` line, and both report skipped tests and cases, which rubytest-tap's never printed. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9 brought the summary, outline, progress and TAP 13 reporters into rubytest, and removed the
-yand-jshortcuts because TAP-Y and TAP-J were left in the separate rubytest-tap gem. This brings those two in as well and restores the shortcuts, so rubytest-tap is no longer needed for any format.Changes
lib/rubytest/format/tapy.rbandtapj.rb, adapted from rubytest-tap 0.1.0. Like the TAP reporter, they take anoutput:stream.-y/--tapyand-j/--tapjare back, and both formats are in the known list.-f tapstill selects TAP 13.AbstractHash#skip_caseno longer calls the publicskip_test, so a subclass that writes each record doesn't write a skipped case twice.Differences from rubytest-tap
...line, which isn't JSON.omit. rubytest-tap's reporters definedomit, which the runner never called, so skips were missing from the stream.Testing
bundle exec rake test: 5 demos, 36 steps, 108 assertions, all passing. A new section indemo/05_builtin_reporters.mdparses both streams and checks the suite record, one record per result, the statuses, and the final counts, and that the shortcuts set the format.rubytest -yandrubytest -jon a file with a passing, a failing and a skipped test: output read by eye.Independent of #10; the two touch different lines.
🤖 Generated with Claude Code