Skip to content

Drop gk7205v200_rubyfpv_generic: not built since 2025 - #262

Merged
openipc-ai merged 1 commit into
masterfrom
drop-gk7205v200-rubyfpv
Nov 21, 2026
Merged

openipc-ai merged 1 commit into
masterfrom
drop-gk7205v200-rubyfpv

Conversation

@openipc-ai

Copy link
Copy Markdown
Contributor

devices/gk7205v200_rubyfpv_generic has been in NOT_BUILT since the old workflow matrix commented it out, before 9168fc2 (2025-05-29). No reason was ever recorded, and no release carries an image for it. Keeping the profile only suggests that a Goke RubyFPV build exists. It doesn't, and openipc.org's installer can't offer one.

  • Removes the device directory: defconfig, kernel config, exclude list and customizer.
  • Drops it from NOT_BUILT in ci-matrix.py. The self-test case "a kernel config in an unbuilt device" used this profile's kernel config, so it now uses hi3518ev200_lite_lenovo-snowman-1080p's, which is also in NOT_BUILT.
  • Removes its shadow entry from .github/firmware-drift.json.

ci-matrix.py --self-test and check-firmware-drift.py --self-test both pass. If RubyFPV on Goke is wanted again, the profile is in git history and can come back together with a working build.

Closes #186.

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

PR Summary by Qodo

Remove the unbuilt Goke RubyFPV device profile

⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Remove the Goke RubyFPV profile, which has no published image and is not built.
• Remove its stale CI exclusion and firmware-drift entry.
• Preserve unbuilt-device test coverage using the Lenovo Snowman kernel config.
Merge Risk 🟢 Low

Blast radius 🟢 Low 💥 0 capabilities

  • Fault-specific containment limits risk to the originating changed behavior.
Behavioral complexity 🟢 Low 🧩 Straightforward

  • The changed logic is a direct removal of a device definition and a corresponding CI opt-out/self-test fixture.
  • It does not introduce a new transformation, compatibility protocol, concurrency interaction or coordinated invariant.
  • The selector continues to use its established device-discovery and NOT_BUILT rules; the changed correctness condition is simply that the removed target must no longer be listed as an opt-out or expected self-test fixture.
Sources

.github/scripts/ci-matrix.py[70-72]

NOT_BUILT = {
    "gk7102ca_lite_umea-qc01x", "gk7102ca_lite_vstarcam-g8896wip",
    "hi3518ev200_lite_lenovo-snowman-1080p",
Potential damage 🟡 Medium 🩹 Temporary loss

  • Conservative damage bound for the originating changed behavior; downstream capabilities remain contained.
  • The affected end-to-end capability is unavailable for this repository snapshot: the RubyFPV profile cannot be selected or built.
  • This is not persistent state corruption, confidentiality loss or an external side effect.
  • Recovery requires restoring/re-adding the device defconfig and associated inputs, then rebuilding; reverting the source change restores the builder capability, but it does not automatically recreate any artifact that users may have expected to download.
  • Existing deployed images remain unchanged.
  • Under the equal-importance baseline, this is a bounded device-specific capability loss rather than a serious or critical system-wide failure.
  • Recoverable by reverting the deletion or restoring the complete device profile and rerunning the build/publish process.
  • No automatic repair worker or state migration is present or required.
Assessed commit 9312fb3
Diagram

graph TD
  D["Device tree"] --> M["CI matrix"] --> B["Build targets"]
  M --> N["NOT_BUILT set"] --> T["Matrix self-test"]
  D --> F["Drift manifest"] --> C["Drift checker"]
Loading
High-Level Assessment

Deleting the unbuilt profile and its stale references is appropriate: retaining or archiving it in the active device tree would continue to imply a supported build. Git history preserves it if a working build is added later.

Files changed (2) +3 / -10

Tests (1) +3 / -3
ci-matrix.pyRemove the obsolete exclusion and replace its test fixture +3/-3

Remove the obsolete exclusion and replace its test fixture

• Removes the deleted profile from NOT_BUILT. The self-test now uses the existing unbuilt Lenovo Snowman kernel config to verify that such changes select no builds.

.github/scripts/ci-matrix.py

Other (1) +0 / -7
firmware-drift.jsonRemove the RubyFPV kernel-config drift entry +0/-7

Remove the RubyFPV kernel-config drift entry

• Removes the reconciliation entry for the deleted Goke RubyFPV kernel config so the drift manifest no longer tracks a nonexistent device file.

.github/firmware-drift.json

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can turn on the rule miner and Qodo learns your standards from review history

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

The profile has sat in NOT_BUILT since the old matrix commented it out, with
no reason recorded and no published image. Keeping it only implied a RubyFPV
build for Goke that nobody ships. Its kernel config was the ci-matrix
self-test case for a file in an unbuilt device; the Lenovo Snowman's kernel
config takes that role, and its firmware-drift shadow entry goes with it.
@openipc-ai
openipc-ai force-pushed the drop-gk7205v200-rubyfpv branch from d5c112b to 9312fb3 Compare November 21, 2026 12:04
@openipc-ai
openipc-ai merged commit a3faed5 into master Nov 21, 2026
148 checks passed
@openipc-ai
openipc-ai deleted the drop-gk7205v200-rubyfpv branch November 21, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gk7205v200_rubyfpv_generic has not been built since 2025: build it, or drop it?

1 participant