Repository navigation
don't remove new EndpointDocuments due to throughput check - #6146
PhilBastian wants to merge 11 commits into
Conversation
… recent throughput check
This comment was marked as outdated.
This comment was marked as outdated.
…be used to prevent removal of entities that have only just been created but not yet populated with throughput
|
requested review from SQL persistence team to ensure the SQL migration is correct |
|
|
||
| public string? Scope { get; set; } | ||
|
|
||
| public DateTime? CreatedDate { get; set; } |
There was a problem hiding this comment.
Given that we haven't released EF, we probably should make this non nullable?
There was a problem hiding this comment.
won't that be confusing for future maintenance purposes if RavenDB and EF entities differ?
There was a problem hiding this comment.
Not really, to me it is more correct given the direction we are going.
There was a problem hiding this comment.
discussed with Andreas. We will change this and leave a comment on the RavenDB entity
rbev
left a comment
There was a problem hiding this comment.
Only did a quick review, but the EF migrations look fine to me.
…ionedEndpointRemovalHostedService.cs Co-authored-by: John Simons <john.simons@particular.net>
…ionedEndpointRemovalHostedService.cs Co-authored-by: John Simons <john.simons@particular.net>
andreasohlund
left a comment
There was a problem hiding this comment.
Tested against the #6142 repro on RabbitMQ 3.10.5, on a fresh database and one upgraded from 6.22.2. Fixed.
| /// <summary> | ||
| /// Removes EndpointDocument/LicensingEndpoint entities that haven't seen throughput for ThroughputReporting.ReportedMonths, | ||
| /// since these can be considered to be decommissioned | ||
| /// </summary> |
There was a problem hiding this comment.
docs/throughput-collection.md doesn't say when endpoints are removed. A short paragraph would help: a daily cleanup removes endpoints without throughput in the reporting window, new endpoints get a one-day grace period, and reads no longer remove anything (#6142). The description should also list the docs pages reviewed (AGENTS.md, "Code changes").
if the EndpointDocument is new then don't remove it as part of the no recent throughput check
The decommissioned endpoints check has been moved out of the endpoint read and into its own hosted service. While this will no longer give an infallible list without any decommissioned endpoints, the difference of 1 day on the entire renewal period doesn't have a realistic impact
fixes #6142