Skip to content

don't remove new EndpointDocuments due to throughput check - #6146

Open
PhilBastian wants to merge 11 commits into
masterfrom
6142_endpointdocument_removal_check
Open

PhilBastian wants to merge 11 commits into
masterfrom
6142_endpointdocument_removal_check

Conversation

@PhilBastian

@PhilBastian PhilBastian commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

if the EndpointDocument is new then don't remove it as part of the no recent throughput check

The decommissioned endpoints check has been moved out of the endpoint read and into its own hosted service. While this will no longer give an infallible list without any decommissioned endpoints, the difference of 1 day on the entire renewal period doesn't have a realistic impact

fixes #6142

@PhilBastian

This comment was marked as outdated.

@PhilBastian
PhilBastian removed the request for review from andreasohlund November 17, 2026 02:02
@andreasohlund
andreasohlund self-requested a review November 17, 2026 14:43
@PhilBastian
PhilBastian requested review from johnsimons, rbev and warwickschroeder and a balanced review from Copilot November 18, 2026 04:26
@PhilBastian
PhilBastian marked this pull request as ready for review November 18, 2026 04:27
@PhilBastian

Copy link
Copy Markdown
Contributor Author

requested review from SQL persistence team to ensure the SQL migration is correct

This comment was marked as outdated.


public string? Scope { get; set; }

public DateTime? CreatedDate { get; set; }

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we haven't released EF, we probably should make this non nullable?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't that be confusing for future maintenance purposes if RavenDB and EF entities differ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, to me it is more correct given the direction we are going.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed with Andreas. We will change this and leave a comment on the RavenDB entity

@rbev rbev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only did a quick review, but the EF migrations look fine to me.

PhilBastian and others added 2 commits November 18, 2026 14:44
…ionedEndpointRemovalHostedService.cs

Co-authored-by: John Simons <john.simons@particular.net>
…ionedEndpointRemovalHostedService.cs

Co-authored-by: John Simons <john.simons@particular.net>

@andreasohlund andreasohlund left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against the #6142 repro on RabbitMQ 3.10.5, on a fresh database and one upgraded from 6.22.2. Fixed.

Comment on lines +8 to +11
/// <summary>
/// Removes EndpointDocument/LicensingEndpoint entities that haven't seen throughput for ThroughputReporting.ReportedMonths,
/// since these can be considered to be decommissioned
/// </summary>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/throughput-collection.md doesn't say when endpoints are removed. A short paragraph would help: a daily cleanup removes endpoints without throughput in the reporting window, new endpoints get a one-day grace period, and reads no longer remove anything (#6142). The description should also list the docs pages reviewed (AGENTS.md, "Code changes").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opening the usage page shortly after startup deletes broker endpoints and stops usage collection

5 participants