Repository navigation
fix(bind): return error for unsupported map value types- #7 - #3236
Open
its-ernest wants to merge 2 commits into
Open
its-ernest wants to merge 2 commits into
its-ernest wants to merge 2 commits into
Conversation
Binding to a map whose value type is not string, []string or any silently returned nil and left the destination untouched. Return a descriptive error instead. Fixes #1
Add public API tests for supported map destinations and for map destinations with unsupported value types via query and header binding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3235.
bindDatasilently returnednilfor map destinations whose value type is notstring,[]stringorany, leaving the destination untouched while reporting success. It now returns a descriptive error instead.Behavior change
Binding to an unsupported map value type (for example
map[string]int) now returns400 Bad RequestthroughBindQueryParams/BindPathValues/BindHeaders/ form binding, rather than silently succeeding without binding.Test plan
go test ./...TestDefaultBinder_bindDataToMapto assert the error formap[string]intandmap[string][]int(with and without a nil map)