Repository navigation
fix(bind): reject unsupported map value types (#3235) - #3238
Merged
Merged
Conversation
Binding path, query, header, or form data into a map whose value type is not string, []string, or any used to skip silently, and named string types panicked in SetMapIndex. bindData now returns an error for these destinations. DefaultBinder.Bind ignores that error when a JSON or XML body will be decoded into the map, so map[string]int with path params and a JSON body still binds. Fixes #3235 Supersedes #3236 Co-authored-by: its-ernest <204517848+its-ernest@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3235. Supersedes #3236. Thanks to @its-ernest for the report and the first fix, which is credited as co-author.
What changed
bindDatanow returns an error when path, query, header, or form data is bound into a map whose value type is notstring,[]string, orany. Before, these values were silently skipped.SetMapIndex; they now return the same error.DefaultBinder.Bindignores that error when a JSON or XML body will be decoded into the map. Somap[string]inton a route with path params and a JSON body still binds (fix(bind): return error for unsupported map value types- #7 #3236 returned 400 there).Behavior change
Calling
BindPathValues,BindQueryParams, orBindHeadersdirectly with an unsupported map type now returns 400 instead of nil.c.Bindinto such a map with path or query params and no body also returns 400 now.Testing
go test -race ./...passes.🤖 Generated with Claude Code