Skip to content

[3.15] gh-162170: Makefile: have "install" depend on pgo (GH-95287) - #162176

Merged
itamaro merged 1 commit into
python:3.15from
miss-islington:backport-715d34f-3.15
Nov 17, 2026
Merged

itamaro merged 1 commit into
python:3.15from
miss-islington:backport-715d34f-3.15

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Previously, make install would ignore PGO. This isn't an
issue if one runs make && make install, since make will
build with pgo (if requested) and then make install won't
rebuild anything.

But if one simply does ./configure --enable-optimizations && make install,
the build system would build a non-PGO build and then install that.

This commit changes the Makefile so that install depends on
all, which includes PGO when requested.
(cherry picked from commit 715d34f)

Co-authored-by: Kevin Modzelewski kmod@users.noreply.github.com

@python-cla-bot

python-cla-bot Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

Previously, `make install` would ignore PGO. This isn't an
issue if one runs `make && make install`, since `make` will
build with pgo (if requested) and then `make install` won't
rebuild anything.

But if one simply does `./configure --enable-optimizations && make install`,
the build system would build a non-PGO build and then install that.

This commit changes the Makefile so that `install` depends on
`all`, which includes PGO when requested.
(cherry picked from commit 715d34f)

Co-authored-by: Kevin Modzelewski <kevmod@gmail.com>
@itamaro
itamaro force-pushed the backport-715d34f-3.15 branch from 083d251 to 688a6a7 Compare November 17, 2026 21:09
@itamaro
itamaro enabled auto-merge (squash) November 17, 2026 21:10
@itamaro
itamaro merged commit 094f7fe into python:3.15 Nov 17, 2026
48 checks passed
@miss-islington
miss-islington deleted the backport-715d34f-3.15 branch November 17, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants