Repository navigation
[3.14] gh-162170: Makefile: have "install" depend on pgo (GH-95287) - #162177
Merged
Merged
Conversation
This was referenced Nov 17, 2026
Previously, `make install` would ignore PGO. This isn't an issue if one runs `make && make install`, since `make` will build with pgo (if requested) and then `make install` won't rebuild anything. But if one simply does `./configure --enable-optimizations && make install`, the build system would build a non-PGO build and then install that. This commit changes the Makefile so that `install` depends on `all`, which includes PGO when requested. (cherry picked from commit 715d34f) Co-authored-by: Kevin Modzelewski <kevmod@gmail.com>
itamaro
force-pushed
the
backport-715d34f-3.14
branch
from
November 17, 2026 21:09
d230911 to
8703290
Compare
itamaro
enabled auto-merge (squash)
November 17, 2026 21:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
make installwould ignore PGO. This isn't anissue if one runs
make && make install, sincemakewillbuild with pgo (if requested) and then
make installwon'trebuild anything.
But if one simply does
./configure --enable-optimizations && make install,the build system would build a non-PGO build and then install that.
This commit changes the Makefile so that
installdepends onall, which includes PGO when requested.(cherry picked from commit 715d34f)
Co-authored-by: Kevin Modzelewski kmod@users.noreply.github.com
make installright after./configure --enable-optimizationsinstalls a non-PGO interpreter #162170